Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update base64 to 0.5.0 #45440

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of base64 to 0.5.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Nov 13, 2022
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes config.h. /cc @facutuesca

@facutuesca
Copy link
Contributor

Removes config.h. /cc @facutuesca

@targos Looks like config.h is not present in the upstream repo, but rather is a file that should be generated during build either with make or cmake.

Maybe it would make more sense to adapt Node's build to generate that file (instead of hardcoding it), since it's the workflow best supported by upstream?

@facutuesca
Copy link
Contributor

@targos @jasnell Let's close this one, I created a PR here so that the script that updates base64 also creates the config.h file. With that change, the automatically-generated update PRs should work out of the box

@targos targos closed this Nov 18, 2022
@targos targos deleted the actions/tools-update-base64 branch November 18, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants