Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make scripts in gyp run with right python #45435

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

gengjiawen
Copy link
Member

Similar to #39730. I run into issues on m1 macOS 13.0

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 12, 2022
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 12, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

@gengjiawen gengjiawen removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 14, 2022
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45435
✔  Done loading data for nodejs/node/pull/45435
----------------------------------- PR info ------------------------------------
Title      build: make scripts in gyp run with right python (#45435)
Author     Jiawen Geng  (@gengjiawen)
Branch     gengjiawen:fix/v8 -> nodejs:main
Labels     v8 engine, tools, needs-ci
Commits    1
 - build: make scripts in gyp run with right python
Committers 1
 - Jiawen Geng 
PR-URL: https://github.com/nodejs/node/pull/45435
Reviewed-By: Luigi Pinca 
Reviewed-By: Ujjwal Sharma 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45435
Reviewed-By: Luigi Pinca 
Reviewed-By: Ujjwal Sharma 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 12 Nov 2022 04:39:11 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45435#pullrequestreview-1178150507
   ✔  - Ujjwal Sharma (@ryzokuken): https://github.com/nodejs/node/pull/45435#pullrequestreview-1178494322
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-11-14T08:03:56Z: https://ci.nodejs.org/job/node-test-pull-request/47878/
- Querying data for job/node-test-pull-request/47878/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3459513650

@gengjiawen gengjiawen merged commit dbce478 into nodejs:main Nov 14, 2022
@gengjiawen gengjiawen deleted the fix/v8 branch November 14, 2022 08:36
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
PR-URL: #45435
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45435
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45435
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45435
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45435
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants