Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 031b98b25cba #45375

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Commits on Nov 8, 2022

  1. deps: V8: cherry-pick 031b98b25cba

    Original commit message:
    
        [runtime] Clear array join stack when throwing uncatchable
    
        ... exception.
    
        Array#join depends array_join_stack to avoid infinite loop
        and ensures symmetric pushes/pops through catch blocks to
        correctly maintain the elements in the join stack.
        However, the stack does not pop the elements and leaves in
        an invalid state when throwing the uncatchable termination
        exception. And the invalid join stack state will affect
        subsequent Array#join calls. Because all the terminate
        exception will be handled by Isolate::UnwindAndFindHandler,
        we could clear the array join stack when unwinding the terminate
        exception.
    
        Bug: v8:13259
        Change-Id: I23823e823c5fe0b089528c5cf654864cea78ebeb
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3878451
        Reviewed-by: Jakob Linke <[email protected]>
        Commit-Queue: 王澳 <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#83465}
    
    Refs: v8/v8@031b98b
    Closes: nodejs#44417
    targos committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    16806ab View commit details
    Browse the repository at this point in the history