test: add postject to fixtures #45298

RaisinTen · 2022-11-03T11:23:24Z

This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm.

This is needed for #45038.

Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76
Signed-off-by: Darshan Sen [email protected]

cc @nodejs/single-executable

Trott

Rubber-stamp LGTM.

Trott · 2022-11-23T16:25:03Z

(It does feel a bit strange adding something to test/fixtures without also adding something somewhere else that uses it, but I'm not going to worry about that if no one else is. I assume the plan is to use it in subsequent PRs.)

Trott · 2022-11-23T16:26:36Z

test/fixtures/postject-copy/package.json

+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC",


Optional nit: If this is code we're authoring and not copying from somewhere else, perhaps we should use the license that we use for the entire code base instead?

Suggested change

"license": "ISC",

"license": "MIT",

richardlau · 2022-11-23T16:28:36Z

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

cjihrig

LGTM with the suggested license change.

Trott · 2022-11-23T16:29:46Z

Do we need to update tools/license-builder.sh? We list things like gtest and ESLint that we include as part of the code base, so I think the answer is "yes"?

Trott · 2022-11-23T16:35:54Z

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

Is this a blocker or merely a raised eyebrow?

Trott

I'm pretty sure we need to add postject to tools/license-builder.sh. Other than that, though, seems OK to me.

mhdawson · 2022-11-23T20:31:07Z

In order to address this concern

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

Could we intergrate similar to https://github.com/nodejs/node/tree/main/tools/lint-md where what gets added is any additional wrappers needed by the test as well as a package.json which as part of the make test would be installed ?

I think https://github.com/nodejs/node/tree/main/tools/clang-format would be another example of a tool that we do something similar for.

RaisinTen · 2022-11-24T13:13:46Z

FWIW, if the concern is about the size of the thing being added, we already include eslint - https://github.com/nodejs/node/tree/main/tools/node_modules/eslint which is 21MB and postject is smaller than that.

Regarding this being a blob, which is not something Linux distros like because it's unreadable - it's not something that should affect them because this will not get built as a part of the node binary.

So I'm not sure how this can be a problem.

RaisinTen · 2022-12-05T11:49:26Z

I'm pretty sure we need to add postject to tools/license-builder.sh. Other than that, though, seems OK to me.

@Trott done, PTAL

EDIT: Oh, nvm. Looks like tools/license-builder.sh failed, that's why the LICENSE file wasn't updated here. It's failing because downloading files from the raw github links like

node/tools/license-builder.sh

Line 72 in 1287530

    
           licenseText="$(curl -sL https://raw.githubusercontent.com/bestiejs/punycode.js/HEAD/LICENSE-MIT.txt)"

seems to be timing out for some reason. 🤔

license has been added to tool

This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm. This is needed for nodejs#45038. Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76 Signed-off-by: Darshan Sen <[email protected]>

RaisinTen · 2022-12-13T10:55:06Z

Turns out it was a connection issue from my end. I switched to a different network to run the script, so now the license changes should be okay. PTAL.

nodejs-github-bot · 2022-12-14T05:44:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48463/

RaisinTen · 2022-12-14T12:13:04Z

Can someone PTAL?

bnb

RSLGTM

nodejs-github-bot · 2022-12-15T05:37:29Z

Landed in 167d7a9

This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm. This is needed for #45038. Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #45298 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 3, 2022

RaisinTen mentioned this pull request Nov 3, 2022

src: add initial support for single executable applications #45038

Merged

RaisinTen added the review wanted PRs that need reviews. label Nov 9, 2022

tony-go approved these changes Nov 10, 2022

View reviewed changes

aymen94 approved these changes Nov 10, 2022

View reviewed changes

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

Trott approved these changes Nov 23, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2022

Trott reviewed Nov 23, 2022

View reviewed changes

cjihrig approved these changes Nov 23, 2022

View reviewed changes

Trott previously requested changes Nov 23, 2022

View reviewed changes

github-actions bot mentioned this pull request Nov 24, 2022

CI Reliability 2022-11-24 nodejs/reliability#438

Open

16 tasks

RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 24, 2022

RaisinTen force-pushed the test/add-postject-to-fixtures branch from 2e38379 to 51a53c8 Compare December 5, 2022 11:48

RaisinTen force-pushed the test/add-postject-to-fixtures branch from 51a53c8 to 32cd1fe Compare December 13, 2022 10:53

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Dec 14, 2022

CI Reliability 2022-12-14 nodejs/reliability#457

Open

12 tasks

RaisinTen requested review from Trott and cjihrig December 14, 2022 12:13

bnb approved these changes Dec 14, 2022

View reviewed changes

github-actions bot mentioned this pull request Dec 15, 2022

CI Reliability 2022-12-15 nodejs/reliability#458

Open

9 tasks

RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Dec 15, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2022

nodejs-github-bot merged commit 167d7a9 into nodejs:main Dec 15, 2022

RaisinTen deleted the test/add-postject-to-fixtures branch December 15, 2022 05:38

This was referenced Dec 16, 2022

CI Reliability 2022-12-16 nodejs/reliability#459

Open

CI Reliability 2022-12-17 nodejs/reliability#460

Open

RafaelGSS mentioned this pull request Jan 2, 2023

v19.4.0 proposal #46061

Merged

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

RaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add postject to fixtures #45298

test: add postject to fixtures #45298

RaisinTen commented Nov 3, 2022

Trott left a comment

Trott commented Nov 23, 2022

This comment was marked as outdated.

Trott Nov 23, 2022

richardlau commented Nov 23, 2022

cjihrig left a comment

Trott commented Nov 23, 2022

Trott commented Nov 23, 2022

Trott left a comment

mhdawson commented Nov 23, 2022

RaisinTen commented Nov 24, 2022

RaisinTen commented Dec 5, 2022 •

edited

Loading

RaisinTen commented Dec 13, 2022 •

edited

Loading

This comment was marked as outdated.

nodejs-github-bot commented Dec 14, 2022

RaisinTen commented Dec 14, 2022

bnb left a comment

nodejs-github-bot commented Dec 15, 2022

test: add postject to fixtures #45298

test: add postject to fixtures #45298

Conversation

RaisinTen commented Nov 3, 2022

Trott left a comment

Choose a reason for hiding this comment

Trott commented Nov 23, 2022

This comment was marked as outdated.

Trott Nov 23, 2022

Choose a reason for hiding this comment

richardlau commented Nov 23, 2022

cjihrig left a comment

Choose a reason for hiding this comment

Trott commented Nov 23, 2022

Trott commented Nov 23, 2022

Trott left a comment

Choose a reason for hiding this comment

mhdawson commented Nov 23, 2022

RaisinTen commented Nov 24, 2022

RaisinTen commented Dec 5, 2022 • edited Loading

RaisinTen commented Dec 13, 2022 • edited Loading

This comment was marked as outdated.

nodejs-github-bot commented Dec 14, 2022

RaisinTen commented Dec 14, 2022

bnb left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 15, 2022

RaisinTen commented Dec 5, 2022 •

edited

Loading

RaisinTen commented Dec 13, 2022 •

edited

Loading