Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: print nghttp2 logs when using debug-nghttp2 #45209

Closed
wants to merge 2 commits into from
Closed

src: print nghttp2 logs when using debug-nghttp2 #45209

wants to merge 2 commits into from

Conversation

santigimeno
Copy link
Member

@santigimeno santigimeno commented Oct 27, 2022 •
edited
Loading

Also, pass --debug-nghttp2 to configure on Windows which for some reason wasn't being done.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 27, 2022 •
edited by santigimeno
Loading

Review requested:

  • @nodejs/gyp
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 27, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2022
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 27, 2022
@github-actions
Copy link
Contributor

null

@aduh95 aduh95 mentioned this pull request Oct 27, 2022
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Oct 27, 2022
@aduh95
tools: fix request-ci-failed comment
1b75e6b 
Refs: nodejs#45209 (comment)
@aduh95 aduh95 mentioned this pull request Oct 27, 2022
Merged
RafaelGSS
RafaelGSS reviewed Oct 28, 2022
View reviewed changes
vcbuild.bat
@@ -197,6 +197,7 @@ if defined link_module set configure_flags=%configure_flags% %link_module%
if defined i18n_arg set configure_flags=%configure_flags% --with-intl=%i18n_arg%
if defined config_flags set configure_flags=%configure_flags% %config_flags%
if defined target_arch set configure_flags=%configure_flags% --dest-cpu=%target_arch%
if defined debug_nghttp2 set configure_flags=%configure_flags% --debug-nghttp2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it is needed? Looks like line 142 does everything needed

if /i "%1"=="debug-nghttp2" set debug_nghttp2=1&goto arg-ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it is. We need to pass the --debug-nghttp2 option to configure so it reaches gyp.

nodejs-github-bot pushed a commit that referenced this pull request Oct 28, 2022
@aduh95
tools: fix request-ci-failed comment
1422e51 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@santigimeno santigimeno added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47529/

@santigimeno santigimeno added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47541/

@github-actions github-actions bot mentioned this pull request Oct 29, 2022
Open
15 tasks
@santigimeno santigimeno added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2022
This was referenced Oct 30, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
tools: fix request-ci-failed comment
f7d4f0a 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Nov 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a5c6f3e...5e74cb6

nodejs-github-bot pushed a commit that referenced this pull request Nov 1, 2022
@santigimeno @nodejs-github-bot
build,win: pass --debug-nghttp2 to configure
159cf51 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 1, 2022
@santigimeno @nodejs-github-bot
src: print nghttp2 logs when using --debug-nghttp2
5e74cb6 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Open
15 tasks
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@santigimeno
build,win: pass --debug-nghttp2 to configure
34122f4 
PR-URL: nodejs#45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@santigimeno
src: print nghttp2 logs when using --debug-nghttp2
4307725 
PR-URL: nodejs#45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
tools: fix request-ci-failed comment
0738d14 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@santigimeno @RafaelGSS
build,win: pass --debug-nghttp2 to configure
8d7aa53 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@santigimeno @RafaelGSS
src: print nghttp2 logs when using --debug-nghttp2
5d48011 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
tools: fix request-ci-failed comment
4104699 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno @danielleadams
build,win: pass --debug-nghttp2 to configure
b6077e0 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno @danielleadams
src: print nghttp2 logs when using --debug-nghttp2
1a1282c 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
tools: fix request-ci-failed comment
ae0c6b7 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno @danielleadams
build,win: pass --debug-nghttp2 to configure
5e5f073 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno @danielleadams
src: print nghttp2 logs when using --debug-nghttp2
51de263 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
tools: fix request-ci-failed comment
078be3b 
Refs: #45209 (comment)
PR-URL: #45218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@santigimeno @danielleadams
build,win: pass --debug-nghttp2 to configure
61bc27a 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@santigimeno @danielleadams
src: print nghttp2 logs when using --debug-nghttp2
e05ebe8 
PR-URL: #45209
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@santigimeno @nodejs-github-bot @lpinca @anonrig @richardlau @RafaelGSS @aduh95