[v16.x backport] tools: refactor avoid-prototype-pollution lint rule #44926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
18 tasks
MoLow
approved these changes
Oct 10, 2022
juanarbol
force-pushed
the
v16.x-staging
branch
from
02cd9a9
to
54b9635
Compare
15 tasks
aduh95
force-pushed
the
backport-avoid-prototype-pollution
branch
from
871d33d
to
b87d6d3
Compare
github-actions
bot
removed
the
request-ci
|
@juanarbol In case it's not to late / not too much work to integrate this in the 16.18.0 proposal, I think this can land :) (if it's not convenient for you to add it, no worries, it's not urgent at all). |
juanarbol
force-pushed
the
v16.x-staging
branch
from
54b9635
to
18e1766
Compare
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: #43476 Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #44446 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
aduh95
force-pushed
the
backport-avoid-prototype-pollution
branch
from
b87d6d3
to
f8364c5
Compare
github-actions
bot
removed
the
request-ci
19 tasks
richardlau
approved these changes
Nov 23, 2022
richardlau
pushed a commit
that referenced
this pull request
Nov 23, 2022
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: #43476 Backport-PR-URL: #44926 Reviewed-By: Moshe Atlow <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Nov 23, 2022
PR-URL: #44446 Backport-PR-URL: #44926 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
|
Landed in 7c0da6a...cc819b4. |
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Refs: nodejs/node#43475 Backport-PR-URL: nodejs/node#44926 PR-URL: nodejs/node#43475
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: nodejs/node#43476 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44446 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Refs: nodejs/node#43475 Backport-PR-URL: nodejs/node#44926 PR-URL: nodejs/node#43475
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use, and was too strict on some methods. PR-URL: nodejs/node#43476 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44446 Backport-PR-URL: nodejs/node#44926 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
avoid-prototype-pollutionlint rule #43476avoid-prototype-pollutionlint rule #44446268f662e5594dc is a continuation of #43475, it looks like it was missed in #44081.