Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky child-process-fork-regr-gh-2847 #4442

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Dec 27, 2015

Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable.

I'm not sure if the error handling logic is 100% correct here. Is silencing ECONNRESET errors on server-side sockets ever acceptable, or are those particular errors relevant to this test?

/cc @mhdawson @jasnell @indutny @trevnorris

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Dec 27, 2015
@indutny
Copy link
Member

indutny commented Dec 27, 2015

I think I'm fine with this change as long as it fails on unpatched node.js (i.e. before this regression was fixed).

@@ -18,6 +18,11 @@ if (!cluster.isMaster) {
}

var server = net.createServer(function(s) {
s.on('error', function(err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap this in an if (common.isWindows) so it only applies to the affected OS? Or not. Just throwing it out there.

@mscdex
Copy link
Contributor Author

mscdex commented Dec 27, 2015

@indutny Yes, the tests still properly fail before the fix (e.g. node v4.1.1).

@indutny
Copy link
Member

indutny commented Dec 27, 2015

Ok, then one nit by @Trott . Otherwise LGTM

Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.
@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2015

@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2015

Whoa, that was weird... suddenly all kinds of seemingly unrelated issues on Windows.

@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2015

I re-ran them all again and this time it's all green: https://ci.nodejs.org/job/node-test-pull-request/1086/

I'm guessing the previous time it was something CI related?

@jbergstroem
Copy link
Member

@mscdex yeah, not sure what was up with the windows slaves last run.

@Trott
Copy link
Member

Trott commented Dec 28, 2015

Green! Another all green!!!! \o/

@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2015

@mscdex
Copy link
Contributor Author

mscdex commented Dec 29, 2015

Stress test is green! \o/

@jbergstroem
Copy link
Member

its actually called blue.png

@Trott
Copy link
Member

Trott commented Dec 29, 2015

LGTM

mscdex added a commit that referenced this pull request Dec 29, 2015
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: #4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@mscdex
Copy link
Contributor Author

mscdex commented Dec 29, 2015

Landed in 30c0062.

@mscdex mscdex closed this Dec 29, 2015
@mscdex mscdex deleted the fix-win-flaky-test-gh2847 branch December 29, 2015 04:33
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: nodejs#4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: #4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
santigimeno added a commit to santigimeno/node that referenced this pull request Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR nodejs#4442.
Trott pushed a commit to Trott/io.js that referenced this pull request Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR nodejs#4442.

PR-URL: nodejs#5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: nodejs#3635
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: #4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: nodejs#4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
rvagg pushed a commit that referenced this pull request Feb 15, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: #3635
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: nodejs#4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: #3635
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: #3635
stefanmb pushed a commit to stefanmb/node that referenced this pull request Feb 23, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR nodejs#4442.

PR-URL: nodejs#5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: nodejs#3635
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <[email protected]>
Fixes: #3635
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.

PR-URL: nodejs#4442
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants