-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: consolidate environment cleanup queue #44379
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
legendecas
force-pushed
the
shadow-realm/cleanup-callbacks
branch
from
August 24, 2022 18:02
885ed6c
to
d0e5fe4
Compare
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Aug 24, 2022
legendecas
force-pushed
the
shadow-realm/cleanup-callbacks
branch
from
August 28, 2022 17:26
d0e5fe4
to
b712fb6
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 29, 2022
joyeecheung
reviewed
Aug 30, 2022
30 tasks
legendecas
force-pushed
the
shadow-realm/cleanup-callbacks
branch
from
August 31, 2022 16:30
b712fb6
to
0e48bdf
Compare
This was referenced Sep 1, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 2, 2022
This was referenced Sep 3, 2022
joyeecheung
reviewed
Sep 5, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too.
legendecas
force-pushed
the
shadow-realm/cleanup-callbacks
branch
from
September 5, 2022 16:06
0e48bdf
to
60e285a
Compare
17 tasks
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 6, 2022
joyeecheung
approved these changes
Sep 6, 2022
15 tasks
Landed in 0b5b5ed. Thank you for the review! |
legendecas
added a commit
that referenced
this pull request
Sep 7, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too. PR-URL: #44379 Refs: #44348 Refs: #42528 Reviewed-By: Joyee Cheung <[email protected]>
12 tasks
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too. PR-URL: nodejs#44379 Refs: nodejs#44348 Refs: nodejs#42528 Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too. PR-URL: #44379 Refs: #44348 Refs: #42528 Reviewed-By: Joyee Cheung <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too. PR-URL: #44379 Refs: #44348 Refs: #42528 Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
Each Realm tracks its own cleanup hooks and drains the hooks when it is going to be destroyed. Moves the implementations of the cleanup queue to its own class so that it can be used in `node::Realm` too. PR-URL: #44379 Refs: #44348 Refs: #42528 Reviewed-By: Joyee Cheung <[email protected]>
legendecas
added
the
realm
Issues and PRs related to the ShadowRealm API and node::Realm
label
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.
Moves the implementations of the cleanup queue to its own class so that
it can be used in
node::Realm
too.Refs: #44348
Refs: #42528