Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend timeout in Debug mode #4431

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 26, 2015

Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-GH-5504.js.

This change doubles the timeout returned from common.platformTimeout()
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-GH-5504.js.

R=@jbergstroem who hopefully can run this through CI in debug mode to confirm that it fixes a few tests

Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.
@Trott
Copy link
Member Author

Trott commented Dec 26, 2015

CI to make sure nothing blew up in Release mode:
https://ci.nodejs.org/job/node-test-commit/1539/

@jbergstroem
Copy link
Member

@Trott
Copy link
Member Author

Trott commented Dec 26, 2015

Only failure in Release mode is a known-ish flaky test.

@mscdex mscdex added the test Issues and PRs related to the tests. label Dec 27, 2015
@Trott
Copy link
Member Author

Trott commented Dec 27, 2015

Two fewer failures in Debug mode than in previous runs, including the test mentioned above (test-net-GH-5504.js).

@Trott
Copy link
Member Author

Trott commented Dec 30, 2015

Seems LGTM-able, anyone? /cc @nodejs/testing

@jbergstroem
Copy link
Member

I'm not so sure that process.config.target_defaults.default_configuration is the best way to access build type, but I can't say I have anything else in mind. LGTM.

Trott added a commit to Trott/io.js that referenced this pull request Dec 30, 2015
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.

PR-URL: nodejs#4431
Reviewed-By: Johan Bergström <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 30, 2015

Landed in 11136bf

@Trott Trott closed this Dec 30, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.

PR-URL: nodejs#4431
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.

PR-URL: nodejs#4431
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-GH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-GH-5504.js.

PR-URL: #4431
Reviewed-By: Johan Bergström <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
@skomski
Copy link
Contributor

skomski commented Jan 21, 2016

I worked in this PR #3280 on making tests usable in debug mode. It would be better to use process.features.debug to detect the build type but I think process.features was never documented.

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-nodejsGH-5504.js.

This change doubles the timeout returned from `common.platformTimeout()`
when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-nodejsGH-5504.js.

PR-URL: nodejs#4431
Reviewed-By: Johan Bergström <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Oct 26, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

Refs: nodejs#4431 (comment)
Trott added a commit to Trott/io.js that referenced this pull request Oct 27, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs#16537
Ref: nodejs#4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott deleted the debug-mode branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants