test: extend timeout in Debug mode #4431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js.
|
CI to make sure nothing blew up in Release mode: |
|
Only failure in Release mode is a known-ish flaky test. |
|
Two fewer failures in Debug mode than in previous runs, including the test mentioned above (test-net-GH-5504.js). |
|
Seems LGTM-able, anyone? /cc @nodejs/testing |
|
I'm not so sure that |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 30, 2015
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <[email protected]>
|
Landed in 11136bf |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Jan 14, 2016
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-GH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-GH-5504.js. PR-URL: #4431 Reviewed-By: Johan Bergström <[email protected]>
Merged
|
I worked in this PR #3280 on making tests usable in debug mode. It would be better to use |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 26, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. Refs: nodejs#4431 (comment)
2 tasks
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 27, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs#16537 Ref: nodejs#4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug mode slows execution speed. There is work afoot to enable Debug
mode runs on the continuous integration infrastructure for the project.
Some tests are timing out, such as test-net-GH-5504.js.
This change doubles the timeout returned from
common.platformTimeout()when running in Debug mode. It also removes an unused variable from the
aforementioned test-net-GH-5504.js.
R=@jbergstroem who hopefully can run this through CI in debug mode to confirm that it fixes a few tests