-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add support for native Windows ARM64 MSVC #44226
Closed
dennisameling
wants to merge
1
commit into
nodejs:main
from
dennisameling:native-windows-arm64-msbuild-tools
Closed
build: add support for native Windows ARM64 MSVC #44226
dennisameling
wants to merge
1
commit into
nodejs:main
from
dennisameling:native-windows-arm64-msbuild-tools
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
windows
Issues and PRs related to the Windows platform.
labels
Aug 13, 2022
dennisameling
force-pushed
the
native-windows-arm64-msbuild-tools
branch
2 times, most recently
from
August 14, 2022 06:28
e838cd9
to
5aeda6c
Compare
joyeecheung
approved these changes
Aug 15, 2022
lpinca
approved these changes
Aug 16, 2022
lpinca
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
jasnell
approved these changes
Aug 28, 2022
This was referenced Nov 2, 2022
Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022. Refs: nodejs/build#2540 Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/
dennisameling
force-pushed
the
native-windows-arm64-msbuild-tools
branch
from
January 28, 2023 11:53
5aeda6c
to
f7ca15b
Compare
Now that #46228 has been merged, this seems to be the right time to merge this PR too. Just rebased it and ran it on an arm64 device. The build finished successfully and used the native VS2022 arm64 build tools:
|
Superseded by #46420 which just got merged 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022.
Refs: nodejs/build#2540
Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/