Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused var from test-assert.js #4405

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 23, 2015

aethrow is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests.

@Trott Trott added assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests. labels Dec 23, 2015
@jasnell
Copy link
Member

jasnell commented Dec 24, 2015

LGTM

@Trott
Copy link
Member Author

Trott commented Dec 26, 2015

CI: https://ci.nodejs.org/job/node-test-commit/1536/

EDIT: PPC buildbot failures but everything else looks normal.

@jbergstroem
Copy link
Member

Fails looks related to github issues.

Trott added a commit to Trott/io.js that referenced this pull request Dec 26, 2015
`aethrow` is defined as a function returned from makeBlock() but the
function is never used and the call to makeBlock() does not run any
tests.

PR-URL: nodejs#4405
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 26, 2015

Landed in 686a85f

@Trott Trott closed this Dec 26, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
`aethrow` is defined as a function returned from makeBlock() but the
function is never used and the call to makeBlock() does not run any
tests.

PR-URL: nodejs#4405
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
`aethrow` is defined as a function returned from makeBlock() but the
function is never used and the call to makeBlock() does not run any
tests.

PR-URL: #4405
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
`aethrow` is defined as a function returned from makeBlock() but the
function is never used and the call to makeBlock() does not run any
tests.

PR-URL: #4405
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`aethrow` is defined as a function returned from makeBlock() but the
function is never used and the call to makeBlock() does not run any
tests.

PR-URL: nodejs#4405
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants