Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark sequential/test-gc-http-client-onerror as flaky #43957

Closed
wants to merge 1 commit into from
Closed

test: mark sequential/test-gc-http-client-onerror as flaky #43957

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jul 23, 2022 •
edited
Loading

Signed-off-by: Matteo Collina [email protected]

Ref: nodejs/reliability#329

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 23, 2022
@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Jul 23, 2022
@tniessen tniessen mentioned this pull request Jul 23, 2022
Closed
tniessen
tniessen approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sequential/test-gc-http-client is also flaky (just like sequential/test-gc-http-client-timeout).

@mcollina
Copy link
Member Author

Definitely. sequential/test-gc-http-client failed 7 times yesterday like this one.

I opened a PR at a time as it seems how it was done other times, but I'm also ok in massively adding all of them in one.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45613/

@lpinca
Copy link
Member

lpinca commented Jul 23, 2022

It looks like the issue will be fixed by #43949.

@github-actions github-actions bot mentioned this pull request Jul 24, 2022
Open
17 tasks
@lpinca lpinca mentioned this pull request Jul 24, 2022
Closed
@F3n67u
Copy link
Member

F3n67u commented Jul 24, 2022

FYI, #43949 has merged to main branch and fixed test-gc-http-client-onerror test. So this pr could be closed.

@mcollina mcollina closed this Jul 24, 2022
This was referenced Jul 25, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcollina @nodejs-github-bot @lpinca @F3n67u @tniessen