Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: link and style parameter types #4378

Closed
wants to merge 1 commit into from
Closed

doc: link and style parameter types #4378

wants to merge 1 commit into from

Conversation

claudiorodriguez
Copy link
Contributor

Changes the parsing of parameter types, links to MDN or
nodejs docs. See #4350
example: "* {Object}" -> "* "

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Dec 21, 2015
@Fishrock123
Copy link
Contributor

I think this is a good idea, review tbd

@claudiorodriguez
doc: link and style parameter types
baa7875 
Changes the parsing of parameter types, links to MDN or
nodejs docs. See nodejs#4350
example: "* {Object}" -> "* <link to MDN><Object></link>"
@Qard
Copy link
Member

Qard commented Dec 29, 2015

👍 Great idea!

@jasnell
Copy link
Member

jasnell commented Dec 30, 2015

@fansworld-claudio ... several of these docs have recently been changed fairly significantly as I go through and work on some rewrites. This is an excellent change but the PR is going to need to be updated. I could work on that myself, if you'd like.

@claudiorodriguez
Copy link
Contributor Author

@jasnell I did notice your very impressive number of doc PRs... I was thinking of waiting until they got merged to fix the conflicts on this PR since otherwise I'd be duplicating work

@jasnell
Copy link
Member

jasnell commented Dec 31, 2015

Sounds good. Let me know if I can help once you're at that point.
On Dec 30, 2015 2:24 PM, "Claudio Rodriguez" [email protected]
wrote:

@jasnell https://github.com/jasnell I did notice your very impressive
number of doc PRs... I was thinking of waiting until they got merged to fix
the conflicts on this PR since otherwise I'd be duplicating work

—
Reply to this email directly or view it on GitHub
#4378 (comment).

@brendanashworth brendanashworth mentioned this pull request Jan 1, 2016
Closed
@claudiorodriguez claudiorodriguez mentioned this pull request Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudiorodriguez @Fishrock123 @Qard @jasnell @MylesBorins