Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove bullet point referring to Node.js 12 #43744

Merged
merged 1 commit into from
Jul 12, 2022
Merged

doc: remove bullet point referring to Node.js 12 #43744

merged 1 commit into from
Jul 12, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 9, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 9, 2022
@lpinca lpinca changed the title [doc] remove bullet point referring to Node.js 12 doc: remove bullet point referring to Node.js 12 Jul 9, 2022
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2022
@F3n67u F3n67u added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit ed7631d into nodejs:main Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ed7631d

@lpinca lpinca deleted the remove/bullet-point branch July 12, 2022 05:39
targos pushed a commit that referenced this pull request Jul 12, 2022
@lpinca @targos
doc: remove bullet point referring to Node.js 12
e076955 
Refs: #43734 (review)

PR-URL: #43744
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lpinca @nodejs-github-bot @cjihrig @richardlau @aduh95 @RaisinTen @targos @F3n67u