crypto: use ByteSource::Builder in To*Copy #43477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead. Refs: nodejs#43202
tniessen
force-pushed
the
crypto-use-bytesource-builder-in-arraybufferorviewcontents
branch
from
d14d479
to
0e6123d
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
30 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
36 tasks
RaisinTen
approved these changes
Jun 20, 2022
tniessen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 21, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
cc @nodejs/cpp-reviewers |
33 tasks
This was referenced Jun 24, 2022
tniessen
added
review wanted
nodejs-github-bot
removed
the
commit-queue
|
Landed in 42ad967 |
This was referenced Jun 26, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead. Refs: #43202 PR-URL: #43477 Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid manual calls to
MallocOpenSSLinArrayBufferOrViewContentsand use the newByteSource::Builderinstead.Refs: #43202