Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use serial comma in ESM docs #43322

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jun 5, 2022

* [Use serial commas][].

Refs: #11321
Refs: #17384

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 824c8b7 into nodejs:master Jun 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 824c8b7

italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
Refs: nodejs#11321
Refs: nodejs#17384

PR-URL: nodejs#43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43322
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants