Update addons.markdown #4331
Closed
Update addons.markdown #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update link from github.com/rvagg to github.com/nodejs
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <[email protected]>
|
Landed in 4637168 |
|
@jasnell FYI: this is present in docs for the current release as well. (I saw the lts-watch tag, and want to make sure it will update the link in every relevant release.) |
|
Yep. Will definitely make sure it lands in v4. Will need someone to pull it into v5 also |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Dec 22, 2015
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <[email protected]>
|
Thanks for this @nicholaswyoung, I believe this is your first commit to core and even though the change is trivial we appreciate the attention to detail. Welcome on board, we hope you stick around and can find other ways to contribute. |
|
@rvagg It is. I don't know why I waited this long to send a patch, but with the warm welcome that I received—I don't think it will be my last! |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Update link from github.com/rvagg to github.com/nodejs PR-URL: #4331 Reviewed-By: James M Snell <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Update link from github.com/rvagg to github.com/nodejs PR-URL: nodejs#4331 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update link from github.com/rvagg to github.com/nodejs, to remove stale URI.