tools: add avoid-prototype-pollution lint rule
#43308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
LGTM! |
Trott
reviewed
Jun 4, 2022
lib/.eslintrc.yaml
Outdated
| @@ -163,6 +163,7 @@ rules: | |||
| node-core/lowercase-name-for-primitive: error | |||
| node-core/non-ascii-character: error | |||
| node-core/no-array-destructuring: error | |||
| node-core/avoid-prototype-pollution: error | |||
There was a problem hiding this comment.
Non-blocking nit: The other rules are all in alphabetical order, so maybe consider moving this and/or renaming it? (no-pollutable-prototypes or something like that?)
|
@nodejs/linting can this get some reviews please? |
Trott
approved these changes
Jun 10, 2022
github-actions
bot
removed
the
request-ci
aduh95
added
the
author ready
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 93728c6 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43308 Reviewed-By: Rich Trott <[email protected]>
Merged
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 12, 2022
PR-URL: nodejs#43308 Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43308 Reviewed-By: Rich Trott <[email protected]>
15 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43308 Reviewed-By: Rich Trott <[email protected]>
16 tasks
|
Also blocks #43475 |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Aug 1, 2022
PR-URL: nodejs#43308 Reviewed-By: Rich Trott <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Aug 1, 2022
PR-URL: nodejs#43308 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2022
PR-URL: #43308 Backport-PR-URL: #44081 Reviewed-By: Rich Trott <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43308 Backport-PR-URL: nodejs/node#44081 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure the work in #43270 doesn't get reverted.