deps: update V8 to 10.2 #42740

targos · 2022-04-14T14:58:11Z

No description provided.

nodejs-github-bot · 2022-04-14T14:58:16Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2022-04-14T15:00:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43499/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4634/

targos · 2022-04-14T15:06:43Z

/cc @nodejs/build about 43fbd04

I guess the easiest will be to wait for master to be at 19.0.0-pre so x86 can just be skipped on v18.x (until we are ready to backport this).

targos · 2022-04-14T15:09:52Z

Btw, since I was able to cherry-pick a lot of ABI-breaking changes into the 10.1 update, there's only one remaining change to adapt for this to be semver-minor (v8/v8@1ff685d8b1). I'll try to work on it next week.

richardlau · 2022-04-14T15:10:08Z

/cc @nodejs/build about 43fbd04

I guess the easiest will be to wait for master to be at 19.0.0-pre so x86 can just be skipped on v18.x (until we are ready to backport this).

I think I could adjust nodejs/build@abf9ebd to only apply to Node.js 18 (so when master becomes 19 it will automatically start testing on Windows x86 again).

Update: opened nodejs/build#2927.

richardlau · 2022-04-14T15:17:53Z

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

targos · 2022-04-14T15:19:25Z

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

I actually squashed it with 76b0ae4. Would you like to be added as a co-author?

richardlau · 2022-04-14T15:20:01Z

Do we need aac8b85 as well for the V8 CI? (I guess we'll find out 🙂.)

I actually squashed it with 76b0ae4. Would you like to be added as a co-author?

If it's not too much trouble 🙇‍♂️.

Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18. Introduce a new `gteLt` closure for exclusions between two versions. Refs: nodejs/node#42690 Refs: nodejs/node#42740 (comment) Refs: #2921

targos · 2022-04-15T08:04:43Z

@nodejs/platform-ppc fyi: https://ci.nodejs.org/job/node-test-commit-v8-linux/4634/nodes=rhel8-ppc64le,v8test=v8test/testReport/junit/(root)/v8tests/mjsunit_wasm_serialization_with_compilation_hints/

This is with https://github.com/v8/v8/commits/10.2-lkgr

miladfarca · 2022-04-16T16:12:48Z

I can't reproduce it after multiple runs. Checked out this PR as well as v8 10.2-lkgr directly. Could you re-run the test?

PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which was removed. This ensures that the layout of IsolateData doesn't change. Refs: v8/v8@1ff685d PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This reverts commit 35d72bf. PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Create an unused deopt kind to replace `DeoptimizeKind::kSoft`, which was removed. This ensures that the layout of IsolateData doesn't change. Refs: v8/v8@1ff685d PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This reverts commit 35d72bf. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

juanarbol · 2022-05-30T00:00:47Z

I've tried to land/backport this in v16.x with no success :(

sepehrst · 2022-05-30T00:41:08Z

I've tried to land/backport this in v16.x with no success :(

Putting aside the reason behind the failure to backport, Wouldn't this be a semver-major? I think v16 is forever locked to V8 9.4 for the same reason that v18 will be locked to 10.2(Thanks to the forward compatibility patches applied to 10.1 otherwise it would have remained at 10.1) even though it is not reached the LTS phase yet, and v16 is already in LTS.

targos · 2022-05-30T05:30:37Z

This should not land on v16.x, sorry I forgot the label.
@juanarbol this has not been in a current release yet, so it would have been too early to backport to LTS.

juanarbol · 2022-05-31T06:08:08Z

This should not land on v16.x, sorry I forgot the label. @juanarbol this has not been in a current release yet, so it would have been too early to backport to LTS.

It's ok! 💚

Notable changes: * deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 PR-URL: TBD

Notable changes: * deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 PR-URL: #43266

Notable changes: * deps: update undici to 5.3.0 (Node.js GitHub Bot) #43197 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) nodejs#43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) nodejs#42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * deps: upgrade npm to 8.11.0 (npm team) nodejs#43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) nodejs#43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) nodejs#42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) nodejs#42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) nodejs#43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [nodejs#42740](nodejs#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: nodejs#43266

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 14, 2022

This was referenced Apr 14, 2022

Reintroduce x86 Windows support #42690

Closed

deps: update V8 to 10.2 #42115

Closed

richardlau mentioned this pull request Apr 14, 2022

jenkins: run win32 CI on Node.js 19 nodejs/build#2927

Merged

github-actions bot mentioned this pull request Apr 15, 2022

CI Reliability 2022-04-15 nodejs/reliability#252

Open

16 tasks

github-actions bot mentioned this pull request Apr 16, 2022

CI Reliability 2022-04-16 nodejs/reliability#253

Open

16 tasks

github-actions bot mentioned this pull request Apr 17, 2022

CI Reliability 2022-04-17 nodejs/reliability#254

Open

15 tasks

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022

build: reset embedder string to "-node.0"

4df86b9

PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022

tools: update V8 gypfiles for 10.2

27ae617

PR-URL: nodejs#42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

targos removed the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label May 12, 2022

BethGriggs added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels May 16, 2022

targos added a commit that referenced this pull request May 23, 2022

deps: update V8 to 10.2.154.2

b3c8e60

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

targos added a commit that referenced this pull request May 23, 2022

build: reset embedder string to "-node.0"

b8b5e6d

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

targos added a commit that referenced this pull request May 23, 2022

tools: update V8 gypfiles for 10.2

5228028

PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

targos added a commit that referenced this pull request May 23, 2022

Revert "build: make x86 Windows support temporarily experimental"

5eff7b4

This reverts commit 35d72bf. PR-URL: #42740 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

juanarbol added the backport-requested-v16.x label May 30, 2022

targos added dont-land-on-v16.x and removed backport-requested-v16.x labels May 30, 2022

bengl mentioned this pull request May 31, 2022

v18.3.0 proposal #43266

Merged

vweevers mentioned this pull request Jun 6, 2022

Cannot open input file node.lib prebuild/prebuildify#65

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 10.2 #42740

deps: update V8 to 10.2 #42740

targos commented Apr 14, 2022

nodejs-github-bot commented Apr 14, 2022

nodejs-github-bot commented Apr 14, 2022 •

edited by targos

Loading

targos commented Apr 14, 2022

targos commented Apr 14, 2022 •

edited

Loading

richardlau commented Apr 14, 2022 •

edited

Loading

richardlau commented Apr 14, 2022

targos commented Apr 14, 2022

richardlau commented Apr 14, 2022

targos commented Apr 15, 2022

miladfarca commented Apr 16, 2022

juanarbol commented May 30, 2022

sepehrst commented May 30, 2022

targos commented May 30, 2022

juanarbol commented May 31, 2022

deps: update V8 to 10.2 #42740

deps: update V8 to 10.2 #42740

Conversation

targos commented Apr 14, 2022

nodejs-github-bot commented Apr 14, 2022

nodejs-github-bot commented Apr 14, 2022 • edited by targos Loading

targos commented Apr 14, 2022

targos commented Apr 14, 2022 • edited Loading

richardlau commented Apr 14, 2022 • edited Loading

richardlau commented Apr 14, 2022

targos commented Apr 14, 2022

richardlau commented Apr 14, 2022

targos commented Apr 15, 2022

miladfarca commented Apr 16, 2022

juanarbol commented May 30, 2022

sepehrst commented May 30, 2022

targos commented May 30, 2022

juanarbol commented May 31, 2022

nodejs-github-bot commented Apr 14, 2022 •

edited by targos

Loading

targos commented Apr 14, 2022 •

edited

Loading

richardlau commented Apr 14, 2022 •

edited

Loading