Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move one or more collaborators to emeritus #42599

Merged
merged 1 commit into from
Apr 7, 2022
Merged

meta: move one or more collaborators to emeritus #42599

merged 1 commit into from
Apr 7, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Apr 4, 2022
RaisinTen
RaisinTen suggested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. @meixg became a collaborator very recently in #42576.

@marsonya
Copy link
Member

marsonya commented Apr 4, 2022 •
edited
Loading

It seems the script doesn't take the date of addition of the collaborator into consideration (there is no way currently to factor date anyways). So if a collaborator was added recently and they are not active between the day they were added and the day the script was scheduled to run, the collaborator is considered as (erroneously) inactive.

targos
targos reviewed Apr 4, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@meixg
Copy link
Member

meixg commented Apr 4, 2022

My last commit is 7 days ago. Is it because my email in commit info is different from readme？

@aduh95
Copy link
Contributor

aduh95 commented Apr 4, 2022

My last commit is 7 days ago. Is it because my email in commit info is different from readme？

That could be it, I think you'd need to add an entry in the .mailmap file so commits from both email address are counted by the bot.

@aduh95
Copy link
Contributor

aduh95 commented Apr 4, 2022

ping/FYI @boneskull

@Trott Trott requested a review from RaisinTen April 4, 2022 11:16
@Trott
Copy link
Member

Trott commented Apr 4, 2022

Is it because my email in commit info is different from readme？

Yes, the script looks for commits and reviews from the email address in the README. So if commits aren't from that email address and there is no .mailmap entry mapping the commit email to the email in the README, this can happen.

I'll open a PR adding a .mailmap entry for you.

Trott added a commit to Trott/io.js that referenced this pull request Apr 4, 2022
@Trott
meta: update .mailmap and AUTHORS
3af01ab 
Refs: nodejs#42599 (comment)
@Trott Trott mentioned this pull request Apr 4, 2022
Merged
@Trott
Copy link
Member

Trott commented Apr 4, 2022 •
edited
Loading

Coincidentally, it was @boneskull that was the person who suggested an automated process for removing inactive collaborators in the first place.

nodejs-github-bot pushed a commit that referenced this pull request Apr 4, 2022
@Trott
meta: update .mailmap and AUTHORS
d58f408 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@Trott @juanarbol
meta: update .mailmap and AUTHORS
1e3e689 
Refs: nodejs#42599 (comment)

PR-URL: nodejs#42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2022
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
meta: update .mailmap and AUTHORS
75affd0 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
meta: update .mailmap and AUTHORS
7766bf9 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot @Trott
meta: move one or more collaborators to emeritus
2949249 
PR-URL: #42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott force-pushed the actions/inactive-collaborators branch from 9d7ad89 to 2949249 Compare April 7, 2022 05:11
@Trott Trott merged commit 2949249 into master Apr 7, 2022
@Trott
Copy link
Member

Trott commented Apr 7, 2022

Landed in 2949249

@Trott Trott deleted the actions/inactive-collaborators branch April 7, 2022 05:11
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
meta: update .mailmap and AUTHORS
aded002 
Refs: nodejs#42599 (comment)

PR-URL: nodejs#42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@nodejs-github-bot @xtx1130
meta: move one or more collaborators to emeritus
7f50c7f 
PR-URL: nodejs#42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
meta: update .mailmap and AUTHORS
ab01eaf 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@nodejs-github-bot @juanarbol
meta: move one or more collaborators to emeritus
47eb8f0 
PR-URL: #42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
meta: update .mailmap and AUTHORS
3e9d594 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
1c8d06a 
PR-URL: #42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
meta: update .mailmap and AUTHORS
f506a60 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@nodejs-github-bot @targos
meta: move one or more collaborators to emeritus
52bb0d5 
PR-URL: #42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
meta: update .mailmap and AUTHORS
ac1c012 
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
meta: move one or more collaborators to emeritus
0994001 
PR-URL: #42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
meta: update .mailmap and AUTHORS
de7a9b3 
Refs: nodejs/node#42599 (comment)

PR-URL: nodejs/node#42602
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
meta: move one or more collaborators to emeritus
6474026 
PR-URL: nodejs/node#42599
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@meixg meixg meixg approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nodejs-github-bot @marsonya @meixg @aduh95 @Trott @lpinca @targos @RaisinTen