-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify the meaning of legacy status #42269
Merged
nodejs-github-bot
merged 11 commits into
nodejs:master
from
RaisinTen:doc/clarify-the-meaning-of-legacy-status
Mar 14, 2022
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3323b8a
doc: clarify the meaning of legacy status
RaisinTen 128c438
fixup! Update doc/api/documentation.md
RaisinTen 75c4766
mixup! Update doc/api/url.md
RaisinTen d437706
fixup! mixup! Update doc/api/url.md
RaisinTen 471d162
fixup! fixup! mixup! Update doc/api/url.md
RaisinTen e3d9b27
fixup! Update doc/api/deprecations.md
RaisinTen 4273271
doc: clarify the meaning of legacy status
RaisinTen 0334b1c
fixup! Update doc/api/documentation.md
RaisinTen 85ace39
doc: use lowercase for Legacy and Deprecated
RaisinTen 71fa00c
Update doc/api/url.md
RaisinTen cc7d2dd
Update doc/api/url.md
RaisinTen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though not specified anywhere, IMO, the word
ecosystem
is qualified withJavascript
when we are dealing with a topic that is related to language specification,Node.js
when the topic is an API spec, andnpm
when it is a module spec. So may beNode.js ecosystem
is more appropriate here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gireeshpunathil I chose to use "npm ecosystem" here because it's used in the description of the "stable" stability index:
node/doc/api/documentation.md
Lines 38 to 39 in 66db116
Perhaps we can change both in a separate pr?