configure: fix arm vfpv2 #4203
Closed
configure: fix arm vfpv2 #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
bnoordhuis
added
build
|
Hello @plugwash your old debdiff is coming to haunt you ;) |
|
Landed in 84dea1b, thanks. |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 10, 2015
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html PR-URL: #4203 Reviewed-By: Ben Noordhuis <[email protected]>
|
Hey @joerg-krause, it looks like this and #4201 were your first contributions to core! If so, thanks very much for the PRs and welcome on board! |
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html PR-URL: #4203 Reviewed-By: Ben Noordhuis <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html PR-URL: #4203 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html PR-URL: #4203 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The gcc -mfpu flag for VFPv2 is vfp, not vfpv2 (there is no vfpv2) [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html PR-URL: nodejs#4203 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcc
-mfpuflag for VFPv2 isvfp, notvfpv2(there is novfpv2) [1].[1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html