test: fix tls-inception #4195

santigimeno · 2015-12-08T12:50:44Z

Make sure all the data is read before checking its validity.
Remove gotHello variable and just check that the ssl end event
is received.

/cc @indutny

mscdex · 2015-12-08T15:38:31Z

test/parallel/test-tls-inception.js

@@ -13,7 +13,6 @@ var path = require('path');
 var net = require('net');

 var options, a, b, portA, portB;


FWIW portA and portB can be removed too, they're not used.

mscdex · 2015-12-08T15:39:12Z

LGTM

indutny · 2015-12-08T18:42:34Z

One nit from @mscdex , otherwise LGTM. Thanks!

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables.

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket.

santigimeno · 2015-12-08T23:16:37Z

Updated the PR removing the unused variables.

I have also added a fix for the problems reported here #1012 (comment). I have sent this in a separate commit. Is this correct? or should I squash both commits into a single one? or a different PR?

/cc @indutny @mscdex

indutny · 2015-12-09T02:13:28Z

test/parallel/test-tls-inception.js


-var body = new Buffer(4000).fill('A');
+var body = new Buffer(400000).fill('A');


I think this is a bit over the top, probably? What do you think about a compromise with a 40000?

I've used that value to reproduce the ECONNRESET error in OS X consistently.

indutny · 2015-12-10T01:46:49Z

LGTM, thank you!

indutny · 2015-12-10T01:47:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/972/

indutny · 2015-12-10T08:51:56Z

Unrelated test failures, landing!

indutny · 2015-12-10T08:53:46Z

Landed in 86a3bd0 and 3b94991. Thank you!

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

santigimeno · 2015-12-10T09:27:01Z

Thanks

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: nodejs#4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: nodejs#4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

cherry-picked the following from master commit 3b94991 Author: Santiago Gimeno <[email protected]> Date: Tue Dec 8 14:57:22 2015 +0100 test: fix tls-inception flakiness When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: nodejs/node#4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>

santigimeno mentioned this pull request Dec 8, 2015

tls_wrap: slice buffer properly in ClearOut #4184

Closed

JungMinu added the test Issues and PRs related to the tests. label Dec 8, 2015

mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 8, 2015

mscdex reviewed Dec 8, 2015
View reviewed changes

santigimeno added 2 commits December 9, 2015 00:08

test: fix tls-inception

89ff7dd

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables.

santigimeno force-pushed the tls_inception branch from 6929fc3 to 432a86e Compare December 8, 2015 23:09

indutny reviewed Dec 9, 2015
View reviewed changes

indutny closed this Dec 10, 2015

santigimeno deleted the tls_inception branch December 10, 2015 09:26

jasnell added the lts-watch-v4.x label Dec 11, 2015

Fishrock123 mentioned this pull request Dec 15, 2015

v5.3.0 Release Proposal (Stable) #4281

Closed

rvagg mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Dec 30, 2015

MylesBorins mentioned this pull request Jan 19, 2016

V4.2.5 proposal #4768

Merged

santigimeno mentioned this pull request Feb 24, 2016

Intermittent test-tls-inception failure on windows #5386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix tls-inception #4195

test: fix tls-inception #4195

santigimeno commented Dec 8, 2015

mscdex Dec 8, 2015

mscdex commented Dec 8, 2015

indutny commented Dec 8, 2015

santigimeno commented Dec 8, 2015

indutny Dec 9, 2015

santigimeno Dec 9, 2015

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

santigimeno commented Dec 10, 2015

		@@ -13,7 +13,6 @@ var path = require('path');
		var net = require('net');

		var options, a, b, portA, portB;


		var body = new Buffer(4000).fill('A');
		var body = new Buffer(400000).fill('A');

test: fix tls-inception #4195

test: fix tls-inception #4195

Conversation

santigimeno commented Dec 8, 2015

mscdex Dec 8, 2015

Choose a reason for hiding this comment

mscdex commented Dec 8, 2015

indutny commented Dec 8, 2015

santigimeno commented Dec 8, 2015

indutny Dec 9, 2015

Choose a reason for hiding this comment

santigimeno Dec 9, 2015

Choose a reason for hiding this comment

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

indutny commented Dec 10, 2015

santigimeno commented Dec 10, 2015