Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo in js_native_api_v8.cc #41764

Merged
merged 1 commit into from
Feb 2, 2022
Merged

src: fix typo in js_native_api_v8.cc #41764

merged 1 commit into from
Feb 2, 2022

Conversation

caioagiani
Copy link
Contributor

  • src/js_native_api_v8.cc NAPI_AUTO_LENGHTH → NAPI_AUTO_LENGTH

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 30, 2022
@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jan 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42247/

@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Open
28 tasks
@Mesteery Mesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41764
✔  Done loading data for nodejs/node/pull/41764
----------------------------------- PR info ------------------------------------
Title      src: fix typo in js_native_api_v8.cc (#41764)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     caioagiani:patch-1 -> nodejs:master
Labels     c++
Commits    1
 - src: fix typo in js_native_api_v8.cc
Committers 1
 - caioagiani 
PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery 
Reviewed-By: Anna Henningsen 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery 
Reviewed-By: Anna Henningsen 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 30 Jan 2022 03:46:18 GMT
   ✔  Approvals: 8
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41764#pullrequestreview-867072126
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41764#pullrequestreview-867091112
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867094356
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867110760
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867193237
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867199780
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41764#pullrequestreview-867235295
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41764#pullrequestreview-868370661
   ✖  This PR needs to wait 6 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-01-30T19:05:07Z: https://ci.nodejs.org/job/node-test-pull-request/42247/
- Querying data for job/node-test-pull-request/42247/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1774881296

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 31, 2022
This was referenced Feb 1, 2022
Open
Open
@gengjiawen gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4318b23 into nodejs:master Feb 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4318b23

@github-actions github-actions bot mentioned this pull request Feb 3, 2022
Open
41 tasks
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
@caioagiani @VoltrexKeyva
src: fix typo in js_native_api_v8.cc
8ae6ca9 
PR-URL: nodejs#41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 4, 2022
Open
38 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@caioagiani @ruyadorno
src: fix typo in js_native_api_v8.cc
bbfa586 
PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@caioagiani @danielleadams
src: fix typo in js_native_api_v8.cc
339b0e2 
PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@caioagiani @danielleadams
src: fix typo in js_native_api_v8.cc
50fd475 
PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@caioagiani @danielleadams
src: fix typo in js_native_api_v8.cc
1cfc63e 
PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Mesteery Mesteery Mesteery approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.