Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor source map stack trace prepare #41698

Merged

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Jan 25, 2022

• Make use of the logical OR operator (||) for better
readability.
• Remove unnecessary conditional and wrapping.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 25, 2022
• Make use of the logical OR  operator (`||`) for better
readability.
• Remove unnecessary conditional and wrapping.
@VoltrexKeyva VoltrexKeyva force-pushed the refactor-srcmps-prep-stack-trace branch from 3b1c9e9 to 4d20097 Compare January 25, 2022 22:02
@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2022
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2022
@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Jan 28, 2022
@Mesteery Mesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 85eca3d into nodejs:master Jan 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 85eca3d

@VoltrexKeyva VoltrexKeyva deleted the refactor-srcmps-prep-stack-trace branch January 29, 2022 22:07
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
• Make use of the logical OR  operator (`||`) for better
readability.
• Remove unnecessary conditional and wrapping.

PR-URL: #41698
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
• Make use of the logical OR  operator (`||`) for better
readability.
• Remove unnecessary conditional and wrapping.

PR-URL: #41698
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
• Make use of the logical OR  operator (`||`) for better
readability.
• Remove unnecessary conditional and wrapping.

PR-URL: #41698
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
• Make use of the logical OR  operator (`||`) for better
readability.
• Remove unnecessary conditional and wrapping.

PR-URL: #41698
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants