Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-worker-take-heapsnapshot flaky #41253

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

  • Mark test-worker-take-heapsnapshot as flaky on
    arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson [email protected]

- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: nodejs#41204
Refs: nodejs#41209

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 20, 2021
@mhdawson
Copy link
Member Author

Would like to request a fast track on this.

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

test/pummel/pummel.status Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

mhdawson added a commit that referenced this pull request Dec 22, 2021
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41253
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 96a6326

targos pushed a commit that referenced this pull request Jan 14, 2022
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41253
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41253
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: nodejs#41204
Refs: nodejs#41209

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#41253
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
- Mark test-worker-take-heapsnapshot as flaky on
  arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41253
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants