-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-worker-take-heapsnapshot flaky #41253
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: nodejs#41204 Refs: nodejs#41209 Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Dec 20, 2021
Would like to request a fast track on this. |
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
cjihrig
approved these changes
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
Co-authored-by: Colin Ihrig <[email protected]>
21 tasks
mhdawson
added a commit
that referenced
this pull request
Dec 22, 2021
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: #41204 Refs: #41209 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41253 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 96a6326 |
This was referenced Dec 23, 2021
This was referenced Dec 30, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: #41204 Refs: #41209 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41253 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: #41204 Refs: #41209 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41253 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: nodejs#41204 Refs: nodejs#41209 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41253 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: #41204 Refs: #41209 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41253 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson [email protected]