test: suppress compiler warning in test_bigint #40253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the are two of following compiler warnings is generated: In file included from ../test_bigint.c:5: ../test_bigint.c: In function ‘CreateTooBigBigInt’: ../test_bigint.c:120:22: warning: ‘words’ may be used uninitialized [-Wmaybe-uninitialized] This commit initialized the words array to avoid these warnings.
nodejs-github-bot
added
needs-ci
tniessen
approved these changes
Sep 29, 2021
richardlau
approved these changes
Sep 29, 2021
cjihrig
approved these changes
Sep 29, 2021
lpinca
approved these changes
Sep 29, 2021
addaleax
approved these changes
Sep 29, 2021
17 tasks
jasnell
approved these changes
Sep 30, 2021
jasnell
added
author ready
19 tasks
|
Landed in 35dc386. |
danbev
added a commit
that referenced
this pull request
Oct 1, 2021
Currently the are two of following compiler warnings is generated: In file included from ../test_bigint.c:5: ../test_bigint.c: In function ‘CreateTooBigBigInt’: ../test_bigint.c:120:22: warning: ‘words’ may be used uninitialized [-Wmaybe-uninitialized] This commit initialized the words array to avoid these warnings. PR-URL: #40253 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 2, 2021
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Currently the are two of following compiler warnings is generated: In file included from ../test_bigint.c:5: ../test_bigint.c: In function ‘CreateTooBigBigInt’: ../test_bigint.c:120:22: warning: ‘words’ may be used uninitialized [-Wmaybe-uninitialized] This commit initialized the words array to avoid these warnings. PR-URL: #40253 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the are two of following compiler warnings is
generated:
This commit initialized the words array to avoid these warnings.