Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove 'data' and 'end' listener if client parser error #40244

Closed

Conversation

mcollina
Copy link
Member

There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.

Fixes: #40242

There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.

Fixes: nodejs#40242
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Sep 28, 2021
@nodejs-github-bot
Copy link
Collaborator

@mcollina
Copy link
Member Author

cc @terreng

@nodejs-github-bot
Copy link
Collaborator

@mcollina mcollina added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2021
@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2021
@github-actions
Copy link
Contributor

Landed in 4f3eda6...140b25a

@github-actions github-actions bot closed this Sep 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 30, 2021
There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.

Fixes: #40242

PR-URL: #40244
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2021
There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.

Fixes: #40242

PR-URL: #40244
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http: double error emitted after HPE_INVALID_CONSTANT
4 participants