Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update markdown formatting for *.md files #40154

Closed
wants to merge 1 commit into from
Closed

doc: update markdown formatting for *.md files #40154

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 19, 2021

Fix formatting that will change when run through upcoming remark preset.

@Trott
doc: update markdown formatting for *.md files
390f928 
Fix formatting that will change when run through upcoming remark preset.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Sep 19, 2021
@Trott Trott requested a review from aduh95 September 19, 2021 15:33
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2021
mhdawson
mhdawson approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actions
Copy link
Contributor

Landed in d05cca9...549f968

@github-actions github-actions bot closed this Sep 21, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 21, 2021
@Trott @nodejs-github-bot
doc: update markdown formatting for *.md files
549f968 
Fix formatting that will change when run through upcoming remark preset.

PR-URL: #40154
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2021
@Trott @targos
doc: update markdown formatting for *.md files
02a87b0 
Fix formatting that will change when run through upcoming remark preset.

PR-URL: #40154
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@Trott Trott deleted the stardotmd branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @lpinca @cjihrig @mhdawson @aduh95 @nodejs-github-bot