Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] docs: add macOS arm64 status #40127

Closed
wants to merge 1 commit into from
Closed

[v14.x] docs: add macOS arm64 status #40127

wants to merge 1 commit into from

Conversation

mrienstra
Copy link
Contributor

@mrienstra mrienstra commented Sep 15, 2021 •
edited
Loading

Starting with node v16.3.0, I installed & used nvm 0.38.0 (nvm -v) to install v14.17.6 (node -v) arm64 (node -p "process.arch"), on macOS 11.5.2 (sw_vers -productVersion) arm64 (uname -m).

@mrienstra mrienstra mentioned this pull request Sep 15, 2021
Closed
@github-actions github-actions bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v14.x labels Sep 15, 2021
richardlau
richardlau reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay but this needs to target the staging branch (v14.x-staging).

@aduh95 aduh95 changed the base branch from v14.x to v14.x-staging September 15, 2021 18:32
@aduh95 aduh95 changed the title docs(v14): Add macOS arm64 status [v14.x] docs: add macOS arm64 status Sep 15, 2021
@mrienstra
Copy link
Contributor Author

Looks okay but this needs to target the staging branch (v14.x-staging).

Whoops, sorry, you said that in the issue I opened, my bad. Thanks for fixing that!

@mrienstra
Copy link
Contributor Author

@richardlau, what's the next step?

targos pushed a commit that referenced this pull request Oct 25, 2021
@mrienstra @targos
doc: add macOS arm64 experimental status
ee77251 
PR-URL: #40127
Reviewed-By: Richard Lau <[email protected]>
@targos
Copy link
Member

targos commented Oct 25, 2021

Landed in ee77251

Thank you!

@targos targos closed this Oct 25, 2021
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@mrienstra mrienstra deleted the patch-1 branch November 5, 2021 17:58
richardlau pushed a commit that referenced this pull request Nov 25, 2021
@mrienstra @richardlau
doc: add macOS arm64 experimental status
92490d1 
PR-URL: #40127
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Nov 25, 2021
Merged
@legobeat legobeat mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrienstra @targos @richardlau @Mesteery