-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: bump remark-preset-lint-node to 3.0.0 #39755
Conversation
Would it be possible to dedupe the module tree a little bit (I usually delete |
Unfortunately, no, not without additional changes: $ make lint-md
Running JS linter...
Running Markdown linter...
/Users/trott/io.js/tools/lint-md.js:12014
glob$1.Glob;
^
TypeError: Cannot read property 'Glob' of undefined
at Object.<anonymous> (/Users/trott/io.js/tools/lint-md.js:12014:8)
at Module._compile (node:internal/modules/cjs/loader:1101:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
at node:internal/main/run_main_module:17:47
make: *** [tools/.mdlintstamp] Error 1
$ I think this is due to incompatibilities with/between a new Let me make those change now and see if it fixes it. If it does, I'll add that commit to this PR. |
No luck, but I did get it to work without rollup. I think it's time to de-rollup-ify this tool, which I will do right after this lands. (I've got it queued up, but there are some license things to go over and possible other issues that I don't want to hold this PR up with.) |
My comment is non-blocking. |
Landed in fcf8ba4...75bd4da |
PR-URL: #39755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
PR-URL: #39755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
PR-URL: #39755 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
No description provided.