Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update AUTHORS #39636

Closed
wants to merge 1 commit into from
Closed

meta: update AUTHORS #39636

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 2, 2021

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 2, 2021
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@tniessen
Copy link
Member

tniessen commented Aug 3, 2021

Did I miss something that led to the multitude of these PRs? Can't we automate this if it really is necessary to keep the list up-to-date?

@Trott
Copy link
Member Author

Trott commented Aug 3, 2021

Did I miss something that led to the multitude of these PRs? Can't we automate this if it really is necessary to keep the list up-to-date?

Batching the updates results in easy-to-miss errors/duplicate entries. But that's not a big enough problem that it warrants a process that annoys maintainers. So I could stop doing these so frequently. Or we could land @bnb's automation for this and iterate on that: #35831

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

Landed in 79b2c9a...fe3c5a7

@github-actions github-actions bot closed this Aug 4, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 4, 2021
PR-URL: #39636
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39636
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39636
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@Trott Trott deleted the u-a branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants