Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic message for retried tests #3960

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 21, 2015

This is dependent on #3941 being landed first.

Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

R=@indutny

@Trott Trott added the test Issues and PRs related to the tests. label Nov 21, 2015
@Trott
Copy link
Member Author

Trott commented Nov 21, 2015

@mscdex mscdex added the tools Issues and PRs related to the tools directory. label Nov 21, 2015
@indutny
Copy link
Member

indutny commented Nov 21, 2015

Fantastic! LGTM

@Trott
Copy link
Member Author

Trott commented Nov 22, 2015

TL;DR: Ran a few tests to make sure it works as advertised on SmartOS with ECONNREFUSED errors and it looks good.

I doctored up a test that would always fail with ECONNREFUSED and ran it through CI. Here's what it looks like:

not ok 209 test-econnrefused.js
# ECONNREFUSED received, test retried
# events.js:142
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: connect ECONNREFUSED 127.0.0.1:12346
#     at Object.exports._errnoException (util.js:873:11)
#     at exports._exceptionWithHostPort (util.js:896:20)
#     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1066:14)
  ---
  duration_ms: 0.549

See https://ci.nodejs.org/job/node-test-commit-smartos/404/nodes=smartos14-64/console for the full console log.

Then I made it so it would fail with ECONNREFUSED the first time it ran but succeed the second time it ran. Here's what that looks like:

ok 209 test-econnrefused.js
# ECONNREFUSED received, test retried
  ---
  duration_ms: 0.548

For the full console log on that one: https://ci.nodejs.org/job/node-test-commit-smartos/406/nodes=smartos14-64/console

@indutny
Copy link
Member

indutny commented Nov 22, 2015

Still LGTM ;)

@Trott Trott force-pushed the log-retries branch 2 times, most recently from 326fce3 to f9501f6 Compare November 24, 2015 15:55
@Trott
Copy link
Member Author

Trott commented Nov 24, 2015

One last post-rebase CI: https://ci.nodejs.org/job/node-test-commit/1233/

Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

PR-URL: nodejs#3960
Reviewed-By: Fedor Indutny <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 24, 2015

CI failures on arm-fanned and smartos but they both look Jenkins-related and not actual test failures. /cc @nodejs/build

Failures on windows-fanned look unrelated too. I'll confirm previous failures for those two tests and get them added to the flaky test list. :-/

@Trott
Copy link
Member Author

Trott commented Nov 24, 2015

Landed in 41519fd

@Trott Trott closed this Nov 24, 2015
@Trott Trott merged commit 41519fd into nodejs:master Nov 24, 2015
Trott added a commit that referenced this pull request Dec 5, 2015
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

PR-URL: #3960
Reviewed-By: Fedor Indutny <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

PR-URL: #3960
Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

PR-URL: #3960
Reviewed-By: Fedor Indutny <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
@Trott Trott deleted the log-retries branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants