Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add constant declarations for net #3950

Closed
wants to merge 1 commit into from
Closed

benchmark: add constant declarations for net #3950

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

Constant declaration for net is omitted in idle_server.js
Add a constant declaration for constant net

@JungMinu JungMinu changed the title benchmark: add a constant type for net constant benchmark: add a constant type for constant net Nov 21, 2015
@JungMinu JungMinu changed the title benchmark: add a constant type for constant net benchmark: add a constant type for net Nov 21, 2015
@JungMinu JungMinu changed the title benchmark: add a constant type for net benchmark: add a constant declaration for net Nov 21, 2015
@tflanagan
Copy link
Contributor

Could you fix the connections and server declarations too?

@targos
Copy link
Member

targos commented Nov 21, 2015

Can you add a 'use strict'; statement at the first line ?
It should help to fix this.

@JungMinu
Copy link
Member Author

@tflanagan @targos Sure, will do :)

@JungMinu
benchmark: add a constant declaration for net
9230dd6 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

benchmark: add constant declarations for `net`
@JungMinu
Copy link
Member Author

finished and rebased, Thanks :)

@JungMinu JungMinu changed the title benchmark: add a constant declaration for net benchmark: add constant declarations for net Nov 21, 2015
@r-52 r-52 added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 21, 2015
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 21, 2015
@silverwind
Copy link
Contributor

LGTM if you still want to land this. We should eventually include benchmark in ESLint.

@jasnell
Copy link
Member

jasnell commented Jan 29, 2016

LGTM

JungMinu added a commit that referenced this pull request Jan 29, 2016
@JungMinu
benchmark: add a constant declaration for net
4126441 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@JungMinu
Copy link
Member Author

Thanks, landed in 4126441

@JungMinu JungMinu closed this Jan 29, 2016
@JungMinu JungMinu deleted the patch-22 branch January 29, 2016 16:29
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@JungMinu @rvagg
benchmark: add a constant declaration for net
3b6283c 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@JungMinu
benchmark: add a constant declaration for net
2c3e00e 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@JungMinu
benchmark: add a constant declaration for net
a29f501 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@JungMinu
benchmark: add a constant declaration for net
2bae6d8 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@JungMinu
benchmark: add a constant declaration for net
728a799 
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: nodejs#3950
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JungMinu @tflanagan @targos @silverwind @jasnell @mscdex @MylesBorins @r-52