stream: fix pipeline pump #39006
Closed
stream: fix pipeline pump #39006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@VoltrexMaster Thanks for the help. Why not make github change suggestions? That way I can just commit your changes directly.
In general it's better to review the code in the code instead of in comments. |
ronag
commented
Jun 11, 2021
|
@ronag yea sorry, I already know how those work; just placed those in a comment as github doesn't allow suggestions in unchanged lines which for example the |
RaisinTen
reviewed
Jun 11, 2021
Co-authored-by: Darshan Sen <[email protected]>
aduh95
reviewed
Jun 11, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Jun 11, 2021
mcollina
requested changes
Jun 11, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
mcollina
requested changes
Jun 11, 2021
aduh95
reviewed
Jun 11, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
ronag
added
the
author ready
|
@nodejs/streams |
jasnell
approved these changes
Jun 14, 2021
|
Landed in bdcb738 |
jasnell
pushed a commit
that referenced
this pull request
Jun 14, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 15, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
This doesn't land cleanly on v14.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39005