Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: bump remark-preset-lint-node to 2.3.0 #38910

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 2, 2021

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2021
@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label Jun 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

Comment on lines +49765 to +49766
start: location.toPoint(initial + index),
end: location.toPoint(initial + index + [...result].length)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generated or did you read the docs/rel notes and change it manually? Just curious.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from tools/node-lint-md-cli-rollup

Copy link

@Nadasayed129 Nadasayed129 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generated or did you read the docs/rel notes and change it manually? Just curious.

This file is generated from tools/node-lint-md-cli-rollup

PR-URL: nodejs#38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 3, 2021

Landed in e7f941c

targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
PR-URL: #38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38910
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants