Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: use EVP_get_cipherbynid directly #38901

Closed
wants to merge 1 commit into from
Closed

crypto: use EVP_get_cipherbynid directly #38901

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 2, 2021 •
edited
Loading

Small cleanup - instead of calling OBJ_nid2sn(nid) and passing that result to EVP_get_cipherbyname, we can pass the nid directly to EVP_get_cipherbynid.

Works with BoringSSL and OpenSSL both.

@codebytere codebytere requested a review from jasnell June 2, 2021 10:21
@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38488/

@codebytere
Copy link
Member Author

Landed in eb3a448

@codebytere codebytere closed this Jun 6, 2021
codebytere added a commit that referenced this pull request Jun 6, 2021
@codebytere
crypto: use EVP_get_cipherbynid directly
eb3a448 
PR-URL: #38901
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere deleted the tiny-crypto-cleanup branch June 6, 2021 19:17
targos pushed a commit that referenced this pull request Jun 11, 2021
@codebytere @targos
crypto: use EVP_get_cipherbynid directly
6e93c17 
PR-URL: #38901
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
@richardlau
Copy link
Member

Doesn't land cleanly on v14.x-staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codebytere @nodejs-github-bot @richardlau @jasnell @addaleax @tniessen @bl-ue