Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 7.15.0 #38831

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.15.0 #38831

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

@npm-robot npm-robot commented May 28, 2021

v7.15.0 (2021-05-27)

FEATURES

BUG FIXES

DOCUMENTATION

DEPENDENCIES

AUTOMATION

@github-actions github-actions bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 28, 2021
@VoltrexKeyva
Copy link
Member

#38828...?

@npm-robot npm-robot changed the title deps(cli): upgrade npm to 7.15.0 deps: upgrade npm to 7.15.0 May 28, 2021
@darcyclarke
Copy link
Member

@VoltrexMaster #38828 (comment)

@darcyclarke
Copy link
Member

Of note, @gimli01 is looking into why this automation has a larger diff then @lpinca's PR; As noted in #38828 (comment), this PR was generated via a GitHub Action that will be kicked off immediately after our releases going forward (ref. https://github.com/npm/cli/blob/latest/.github/workflows/create-cli-deps-pr.yml)

@Ayase-252
Copy link
Member

Ayase-252 commented May 28, 2021

Maybe it need sync with latest master? I saw This branch is 1 commit ahead, 1359 commits behind nodejs:master. in https://github.com/npm/node/tree/npm-7.15.0

@aduh95
Copy link
Contributor

aduh95 commented May 28, 2021

There is a no-bot but our bots policy in Node.js's repos:

Accounts that are reasonably believed to be bots (other than bots authorized by both TSC and CommComm) are subject to immediate Blocking.

Does @npm-robot fits in the authorized category? Would it be possible to link to an issue where its introduction has been discussed?

@ruyadorno
Copy link
Member

There is a no-bot but our bots policy in Node.js's repos:

Accounts that are reasonably believed to be bots (other than bots authorized by both TSC and CommComm) are subject to immediate Blocking.

Hi @aduh95 thank you so much for bringing that up, personally I wasn't aware of the existence of that policy when I first discussed the npm-robot PR strategy but I can totally see the reason for having it 😊

That said, my personal interpretation of the policy is that it's in place to avoid spamming and other unwanted behavior. That wouldn't be the case here. This robot is clearly performing a legitimate task, helping us better integrate npm cli releases timely into node releases.

Does @npm-robot fits in the authorized category? Would it be possible to link to an issue where its introduction has been discussed?

Could you please help us bring the subject to a future TSC meeting agenda? Given that we have that policy in place I believe the best way to move forward is to make sure get an explicit approval. 🙏

@aduh95 aduh95 added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 31, 2021
@ruyadorno
Copy link
Member

actually, let me create an issue instead and close this PR as I want to make sure we clean things up in the update npm side of things 😊

Opened: #38879 so that we can continue the conversation there.

@ruyadorno ruyadorno closed this May 31, 2021
@ruyadorno ruyadorno removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants