-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: include url in bootstrap snapshot and remove unnecessary lazy-loads #38826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
PRs that need a full CI run.
url
Issues and PRs related to the legacy built-in url module.
labels
May 27, 2021
jasnell
approved these changes
May 27, 2021
targos
approved these changes
May 27, 2021
Apakottur
approved these changes
May 27, 2021
It seems some tests fail with this, some tmp files weren't properly cleaned up after the test finished.
I can't see why this PR would result in a difference, is it a test util bug? @nodejs/testing |
XadillaX
approved these changes
Jun 2, 2021
joyeecheung
added a commit
that referenced
this pull request
Jun 2, 2021
PR-URL: #38826 Refs: #35711 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Landed in 2bb0c20 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 2, 2021
PR-URL: #38826 Refs: #35711 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Merged
This doesn't land cleanly on v14.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #35711