doc: document null target pattern #38724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
To confirm, this works with any node version that supports the object form? |
|
@ljharb yes it's supported in all versions. |
aduh95
approved these changes
May 19, 2021
|
There's a bunch of these tests in https://github.com/nodejs/node/blob/master/test/fixtures/node_modules/pkgexports/package.json. Not for subpath patterns though, but it's a straightforward extension. |
DerekNonGeneric
approved these changes
May 19, 2021
jasnell
approved these changes
May 19, 2021
guybedford
added a commit
that referenced
this pull request
May 20, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 01940ee. |
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38724 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently document
nulltargets in package "exports", which provide a useful exclude functionality when used in subpath patterns. This extends the subpath patterns docs with a short description and example of this behaviour.@nodejs/modules