Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-specific function out of common #3871

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 17, 2015

common.checkSpawnSyncRet() is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).
@Trott Trott added the test Issues and PRs related to the tests. label Nov 17, 2015
@Trott
Copy link
Member Author

Trott commented Nov 17, 2015

@targos
Copy link
Member

targos commented Nov 17, 2015

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Nov 17, 2015
@jasnell
Copy link
Member

jasnell commented Nov 17, 2015

LGTM
@Trott ... for these smaller minor test improvements (like this and #3870)... I'm wondering if it would be more efficient to bundle the commits up into a single PR?

Trott added a commit that referenced this pull request Nov 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 17, 2015

Landed in b385772

@jasnell jasnell closed this Nov 17, 2015
Trott added a commit that referenced this pull request Nov 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this pull request Dec 1, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this pull request Dec 4, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott added a commit that referenced this pull request Dec 23, 2015
common.checkSpawnSyncRet is only used in one test. Move it out of
common.js and into that test (test-child-process-spawnsync-input.js).

PR-URL: #3871
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the checkspawnsyncret branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants