-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add ESM code examples in url.md #38651
Conversation
Switching to When I first saw new URL('file:///C:/path/').pathname; // Incorrect: /C:/path/
fileURLToPath('file:///C:/path/'); // Correct: C:\path\ (Windows) I really don't know how to use
It doesn't make sense to remove these imports. check https://nodejs.org/api/child_process.html, every example has |
|
Yes, with pleasure. |
PR-URL: #38651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
Landed in df744db |
PR-URL: #38651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
Alternative to #38645, removing use of
require
or addingimport
equivalents where it makes sense.@fisker what do you think?