Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set common.bits to 64 for riscv64 #38626

Closed
wants to merge 1 commit into from
Closed

test: set common.bits to 64 for riscv64 #38626

wants to merge 1 commit into from

Conversation

andreas-schwab
Copy link
Contributor

No description provided.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38012/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38029/ 💚

juanarbol
juanarbol approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Such a nice catch

@juanarbol juanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2021
@jasnell
Copy link
Member

jasnell commented May 17, 2021

Landed in 9d85710

@jasnell jasnell closed this May 17, 2021
jasnell pushed a commit that referenced this pull request May 17, 2021
@andreas-schwab @jasnell
test: set common.bits to 64 for riscv64
9d85710 
PR-URL: #38626
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 18, 2021
@andreas-schwab @targos
test: set common.bits to 64 for riscv64
5b25fbe 
PR-URL: #38626
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@marsonya marsonya marsonya approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@andreas-schwab @nodejs-github-bot @jasnell @Trott @lpinca @cjihrig @richardlau @marsonya @juanarbol @targos