Fixes: https://github.com/nodejs/node/issues/38606 #38610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
mscdex
reviewed
May 9, 2021
mscdex
reviewed
May 9, 2021
jasnell
approved these changes
May 10, 2021
marsonya
requested changes
May 11, 2021
|
Hi, thank you for your comments. Please see if everything looks okay. This is my first ever issue that I have contributed to. So any other pointers or direction that I should keep in mind going forward contributing to other issues will be appreciated. :) |
RaisinTen
reviewed
May 11, 2021
marsonya
approved these changes
May 11, 2021
Trott
reviewed
May 12, 2021
Trott
approved these changes
May 12, 2021
Co-authored-by: Rich Trott <[email protected]>
RaisinTen
approved these changes
May 15, 2021
RaisinTen
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38610 Fixes: #38606 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
|
Landed in 5b90748 |
targos
pushed a commit
that referenced
this pull request
May 18, 2021
PR-URL: #38610 Fixes: #38606 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #38610 Fixes: #38606 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38606