Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-zlib-unused-weak.js #38149

Closed
wants to merge 1 commit into from
Closed

Conversation

oyyd
Copy link
Contributor

@oyyd oyyd commented Apr 8, 2021

Failed test: https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-last-latest-x64/40825/testReport/junit/(root)/test/parallel_test_zlib_unused_weak/

AssertionError [ERR_ASSERTION]: Expected after-GC delta -29156 to be less than 5 % of before-GC delta -9751

I think the delta should be positive. Calling gc() before zlib.createGzip() should make it more stable.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37292/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
@lpinca
Copy link
Member

lpinca commented Apr 9, 2021

Fast-track?

@mcollina
Copy link
Member

mcollina commented Apr 9, 2021

+1 to fast track

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2021
oyyd added a commit that referenced this pull request Apr 9, 2021
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@oyyd
Copy link
Contributor Author

oyyd commented Apr 9, 2021

Landed in f96dffb, thanks!

@oyyd oyyd closed this Apr 9, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants