Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown #37997

Closed
wants to merge 3 commits into from
Closed

fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown #37997

wants to merge 3 commits into from

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Mar 31, 2021 •
edited
Loading

Fixes: #37995

Uint32 should be between [0, 2 ** 32)

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Mar 31, 2021
@RaisinTen
Copy link
Contributor

RaisinTen commented Mar 31, 2021 •
edited
Loading

I'm not sure that this is a valid fix for this issue as -1 is actually an accepted value for owner and group. This is almost like a revert of #31694 which added support for -1.

@benjamingr benjamingr mentioned this pull request Mar 31, 2021
Closed
@ycjcl868 ycjcl868 changed the title fix: valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown Apr 1, 2021
@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Apr 1, 2021

Fix by #38004, Closed

@ycjcl868 ycjcl868 closed this Apr 1, 2021
@ycjcl868 ycjcl868 deleted the fs-chown-range branch April 1, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"fs.chownSync" results in an abort
3 participants
@ycjcl868 @RaisinTen @nodejs-github-bot