test: fix flaky test-http2-pack-end-stream-flag #37814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#37639
jasnell
force-pushed
the
fix-flaky-test-http2-pack-end-stream-flag
branch
from
c5a0313
to
6e9ccf6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Mar 19, 2021
jasnell
added
author ready
lpinca
approved these changes
Mar 19, 2021
This comment has been minimized.
This comment has been minimized.
|
Landed in 978bbf9 |
jasnell
added a commit
that referenced
this pull request
Mar 22, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #37639 PR-URL: #37814 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
No, this shouldn't need to be backported
…On Tue, Mar 23, 2021, 18:25 Ruy Adorno ***@***.***> wrote:
hi @jasnell <https://github.com/jasnell> I see this changeset doesn't
land cleanly on v15.x-staging since it builds on top of #37136
<#37136> which is a semver-major
landing only on v16.x.
With that in mind, should we still backport this fix to v15 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37814 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADLM6L7HSQDX75DLSKZPYLTFE5PPANCNFSM4ZO52BRQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell [email protected]
Fixes: #37639