Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Usage of Object::Set() #3780

Closed
wants to merge 6 commits into from
Closed

Commits on Dec 2, 2015

  1. node: fix erroneously named function call

    The initial implementation of setPropByIndex() set the value of an Array
    by index during development. Though the final form of the function
    simply pushes passed values to an array as passed by arguments. Thus the
    functions have been renamed to pushValueToArray() and
    push_values_to_array_function() respectively.
    
    Also add define for maximum number of arguments should be used before
    hitting the limit of performance increase.
    
    Fixes: 494227b "node: improve GetActiveRequests performance"
    trevnorris committed Dec 2, 2015
    Configuration menu
    Copy the full SHA
    4d6d7dd View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2015

  1. http_parser: use pushValueToArray for headers

    For performance add headers to the headers Array by pushing them on from
    JS. Benchmark added to demonstrate this case.
    trevnorris committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    5af27f6 View commit details
    Browse the repository at this point in the history
  2. fs: use pushValueToArray for readdir(Sync)

    Improve performance by pushing directory entries to returned array in
    batches of 8 using pushValueToArray() in JS. Add benchmarks to
    demonstrate this improvement.
    trevnorris committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    f229b67 View commit details
    Browse the repository at this point in the history
  3. node: improve GetActiveHandles performance

    Improve performance of process._getActiveHandles by sending handles in
    batches to JS to be set on the passed Array. Add test to check proper
    active handles are returned.
    
    Alter implementation of GetActiveRequests to match GetActiveHandles'
    implementation.
    trevnorris committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    f3f59a4 View commit details
    Browse the repository at this point in the history
  4. node: improve performance of hrtime()

    process.hrtime() was performing too many operations in C++ that could be
    done faster in JS. Move those operations over by creating a length 4
    Uint32Array and perform bitwise operations on the seconds so that it was
    unnecessary for the native API to do any object creation or set any
    fields.
    
    This has improved performance from ~350 ns/op to ~65 ns/op. Light
    benchmark included to demonstrate the performance change.
    trevnorris committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    fc143da View commit details
    Browse the repository at this point in the history
  5. node: improve accessor perf of process.env

    Set process.env array entries in JS.
    trevnorris committed Dec 3, 2015
    Configuration menu
    Copy the full SHA
    799b440 View commit details
    Browse the repository at this point in the history