deps: V8: cherry-pick 1648e050cade #37664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
targos
approved these changes
Mar 9, 2021
|
Please add |
Trott
approved these changes
Mar 10, 2021
Original commit message:
torque: workaround stod() limitations on Solaris
std::stod() on Solaris does not currently handle hex strings.
This commit provides a workaround based on strtol() until proper
stod() support is available.
This was encountered while updating Node.js to V8 8.8. For more
details see the following comment:
nodejs#36139 (comment)
Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746
Reviewed-by: Michael Stanton <[email protected]>
Commit-Queue: Michael Stanton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73255}
Refs: v8/v8@1648e05
PR-URL: nodejs#37664
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Original commit message:
torque: workaround stod() limitations on Solaris
std::stod() on Solaris does not currently handle hex strings.
This commit provides a workaround based on strtol() until proper
stod() support is available.
This was encountered while updating Node.js to V8 8.8. For more
details see the following comment:
#36139 (comment)
Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746
Reviewed-by: Michael Stanton <[email protected]>
Commit-Queue: Michael Stanton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73255}
Refs: v8/v8@1648e05
PR-URL: #37664
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Original commit message:
torque: workaround stod() limitations on Solaris
std::stod() on Solaris does not currently handle hex strings.
This commit provides a workaround based on strtol() until proper
stod() support is available.
This was encountered while updating Node.js to V8 8.8. For more
details see the following comment:
#36139 (comment)
Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746
Reviewed-by: Michael Stanton <[email protected]>
Commit-Queue: Michael Stanton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73255}
Refs: v8/v8@1648e05
PR-URL: #37664
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message: