Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clear obsolete FLAKY entries #37631

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 6, 2021

test-stream-pipeline-http2 and test-http2-pipe haven't failed for a long time.

Closes: #20750

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

@nodejs/testing This could use another review.

It hasn't failed in a long time.

Refs: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
It hasn't failed for a long time.

Closes: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@Trott Trott merged commit f108778 into nodejs:master Mar 8, 2021
@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

Landed in 8ab6a6c...f108778

@Trott Trott deleted the rm-obsolete-flaky branch March 8, 2021 14:25
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-http2-* on Windows
4 participants