-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: clear obsolete FLAKY entries #37631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Mar 6, 2021
Trott
added
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
http2
Issues or PRs related to the http2 subsystem.
stream
Issues and PRs related to the stream subsystem.
windows
Issues and PRs related to the Windows platform.
labels
Mar 6, 2021
targos
approved these changes
Mar 6, 2021
@nodejs/testing This could use another review. |
ruyadorno
approved these changes
Mar 8, 2021
It hasn't failed in a long time. Refs: nodejs#20750 PR-URL: nodejs#37631 Fixes: nodejs#20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
It hasn't failed for a long time. Closes: nodejs#20750 PR-URL: nodejs#37631 Fixes: nodejs#20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Landed in 8ab6a6c...f108778 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
It hasn't failed in a long time. Refs: #20750 PR-URL: #37631 Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
It hasn't failed for a long time. Closes: #20750 PR-URL: #37631 Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
It hasn't failed in a long time. Refs: #20750 PR-URL: #37631 Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
It hasn't failed for a long time. Closes: #20750 PR-URL: #37631 Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to the stream subsystem.
test
Issues and PRs related to the tests.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-stream-pipeline-http2 and test-http2-pipe haven't failed for a long time.
Closes: #20750